Skip to content

Commit

Permalink
ci: separate linting and testing actions
Browse files Browse the repository at this point in the history
  • Loading branch information
janfb committed Aug 20, 2024
1 parent 3b07f44 commit bf9e92b
Show file tree
Hide file tree
Showing 3 changed files with 65 additions and 25 deletions.
26 changes: 2 additions & 24 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
name: Continuous Integration

on:
push:
branches:
- main
pull_request:
workflow_dispatch:

on: [pull_request, workflow_dispatch]

defaults:
run:
Expand All @@ -17,18 +11,6 @@ concurrency:
cancel-in-progress: true

jobs:
pre-commit:
name: ruff and hooks.
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: '3.8'
- uses: pre-commit/action@v3.0.1
with:
extra_args: --all-files --show-diff-on-failure

ci:
name: CI
runs-on: ubuntu-latest
Expand Down Expand Up @@ -69,10 +51,6 @@ jobs:
pip install torch==${{ matrix.torch-version }} --extra-index-url https://download.pytorch.org/whl/cpu
pip install -e .[dev]
- name: Check types with pyright
run: |
pyright .
- name: Run the tests
- name: Run tests
run: |
pytest -v -x -n auto tests/
62 changes: 62 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
name: Linting

on:
pull_request:
push:
branches: [main]
workflow_dispatch:

defaults:
run:
shell: bash

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.ref }}
cancel-in-progress: true

jobs:
pre-commit:
name: ruff and hooks.
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: '3.8'
- uses: pre-commit/action@v3.0.1
with:
extra_args: --all-files --show-diff-on-failure

pyright:
name: Check types
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
lfs: false

- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.8'

- name: Cache dependency
id: cache-dependencies
uses: actions/cache@v4
with:
path: ~/.cache/pip
key: ubuntu-latest-pip-3.8
restore-keys: |
ubuntu-latest-pip-
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install torch --extra-index-url https://download.pytorch.org/whl/cpu
pip install -e .[dev]
- name: Check types with pyright
run: |
pyright pyknos
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ dev = [
# Lint
"pre-commit == 3.5.0",
"pyyaml",
"pyright == 1.1.355",
"pyright",
"ruff>=0.3.3",
# Test
"pytest",
Expand Down

0 comments on commit bf9e92b

Please sign in to comment.