Collapse stat and save #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're already using vite, so this is the appropriate way to do unit testing.
This was hard to get working, but might be interesting in the future.
Add three sucess tests, as an initial frame for testing.
Each player character shows a summary of their skills in the summarized character sheet in the left bar.
This button does more harm than good until armor is implemented.
The logic of analyseStatRoll and analyseSaveRoll are identical. The logic is somewhat convoluted and does not accurately implement the behavior specified in the rule book. Before fixing it, take the opportunity to solve remove the duplicated code to keep from having to fix it twice.
These are the four detailed roll examples I could find in the PSG. This shook out an error in the logic.
These are a couple of changes missed in commit 2e8ac1b.
This collapses the types of stat and save rolls into one and simplifies the hierarchy. It does not change the function of the rolls, but it does make them easier to maintain.
|
The pull is rather nasty since I've had to corroborate several branches. I'd actually not accept this yet, since there's some extra changes in the middle there. Unfortunately, and this is my fault, I've hacked my code base to the point where it's hard to pull out the changes I need to. I'm sure there's a way to do it with git, or I could manually confect the changes I need, but right now this is what I can do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This collapses the types for the stat rolls and the save rolls into one another. This makes it easier to modify the logic and centralize it. This is mentioned in #6.