refactor: change all relevant CSS properties to logical properties #3033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr: peer review required
github-actions
bot
added
pr: visual review required
diff-available
and removed
preview-available
diff-available
labels
kyubisation
force-pushed
the
style-logical-properties
branch
from
e38f18f
to
b4da001
Compare
github-actions
bot
added
pr: visual review required
diff-available
and removed
pr: visual review required
labels
kyubisation
added
the
pr: blocked
github-actions
bot
removed
the
pr: peer review required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a stylelint plugin to automatically change all relevant CSS properties to logical properties.
Edited by @jeripeierSBB
TODO: Wherever we write calculated CSS vars from Javascript (overlay positioning), we need to keep the top, right, bottom, left positioning. Otherwise, the rtl support gets worse than now.