Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sbb-tooltip): initial implementation #2962

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(sbb-tooltip): initial implementation #2962

wants to merge 1 commit into from
+925 −0

Conversation

kyubisation
Copy link
Contributor

@kyubisation kyubisation commented Jul 25, 2024 •
edited
Loading

This PR implements the tooltip.

To discuss and decide:

  • Is the attribute approach acceptable?
    • Should sbb-tooltip (problems with linter and IDEs) or data-sbb-tooltip be used?
  • Is the overlay controller an acceptable solution for overlays?
  • Should we start using native CSS Anchor Positioning, as it is now partially supported in Chromium based browsers? Wait for improved browser support.
  • UX: Should the tooltip always be below/above or can it be before/after (as currently implemented)?

Still to do:

  • Documentation
  • Tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeripeierSBB jeripeierSBB Awaiting requested review from jeripeierSBB jeripeierSBB will be requested when the pull request is marked ready for review jeripeierSBB is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
target: 1.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyubisation @jeripeierSBB