Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage reporting #7

Merged
merged 15 commits into from
Feb 11, 2015
Merged

Add test coverage reporting #7

merged 15 commits into from
Feb 11, 2015

Conversation

sathomas
Copy link
Owner

@sathomas sathomas commented Feb 6, 2015

No description provided.

@sathomas sathomas self-assigned this Feb 6, 2015
@sathomas
Copy link
Owner Author

sathomas commented Feb 6, 2015

The browser-based testing (grunt serve:test) is working sweetly, but I'm getting lost in the node black hole trying to make it work from the command line (grunt test). Feel free to try your own luck if you like.

@sathomas
Copy link
Owner Author

sathomas commented Feb 7, 2015

Nice update @stuartf. I've tried to build on this by adding support for coveralls.io, but I think we're out of luck. It seems like grunt-blanket-mocha can't generate the .lcov format files that coveralls.io requires. I'm basing that conclusion on my own experiments as well as a couple of open issues on the plugin's repo. If you see an easy way to add this, feel free. Otherwise, we can just remove the coveralls.io stuff and rely on the standard unit tests with code coverage thresholds to catch any problems.

stuartf added a commit that referenced this pull request Feb 11, 2015
Add test coverage reporting
@stuartf stuartf merged commit d75b03e into master Feb 11, 2015
@stuartf stuartf deleted the issue-7 branch February 11, 2015 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants