Skip to content
This repository has been archived by the owner on Nov 19, 2023. It is now read-only.

build(deps): bump foo-software/lighthouse-check-action from 9.0.0 to 10.0.0 #211

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 19, 2023

Bumps foo-software/lighthouse-check-action from 9.0.0 to 10.0.0.

Release notes

Sourced from foo-software/lighthouse-check-action's releases.

Lighthouse 10

This release bumps Lighthouse to version 10. See the article from Google about the interesting changes this version provides.

foo-software/lighthouse-check-action depends on other foo-software GitHub projects. Below are the 2 related PRs.

Adds a small delay in between multiple runs

When multiple Lighthouse audits run via multiple URLs defined in the urls option, some faced an issue in which Lighthouse was not launching Chrome as described in #109.

It seems as though when upgrading our Node.js runner to version 16 the linked issue above started occurring. There seems to be 2 issues at play.

  1. Chrome Launcher intermittently fails to launch and does not throw an error or surface the problem in any way when Lighthouse runs consecutively in GitHub runners, which causes Lighthouse to mysteriously fail as it is unable to connect. It's unclear why this started happening on Node.js@16. lighthouse-persist is the package used that orchestrates Lighthouse and I attempted to detect chrome.pid and add retry logic, but unfortunately there is another issue with Chrome Launcher in which chrome.pid is undefined.
  2. In GitHub's Node 14 runner, when Chrome Launcher failed as described above, the try / catch / retry logic catches the error and succeeds on the first retry as seen here, but in GitHub's Node 16 runner the retry as described above seems to fail and the error bubbles all the way up on the first try and the retry logic isn't triggered as seen here. This is quite unusual, as we use a try / catch block which should catch any errors.

The above are caused by a combination of dependencies that seem to have unclear issues and even unclear sources (GitHub Runners? Chrome Launcher? Lighthouse?). And since these issues are out of our control, the best way I can offer to workaround them, is by adding a 1 second delay in between consecutive Lighthouse audits. My theory is that Chrome Launcher isn't correctly signaling when it is in fact launched and when it has been killed and therefore by giving it some time, we cushion the real problem.

Miscellaneous Dependency Upgrades

No release notes provided.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [foo-software/lighthouse-check-action](https://github.com/foo-software/lighthouse-check-action) from 9.0.0 to 10.0.0.
- [Release notes](https://github.com/foo-software/lighthouse-check-action/releases)
- [Changelog](https://github.com/foo-software/lighthouse-check-action/blob/master/tsconfig.release.json)
- [Commits](foo-software/lighthouse-check-action@v9.0.0...v10.0.0)

---
updated-dependencies:
- dependency-name: foo-software/lighthouse-check-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants