NEM_SLICE: Fix bad logic in 1D border element determination

sandialabs · Jul 29, 2024 · 2957d9c · 2957d9c
1 parent 407665c
commit 2957d9c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 13 deletions.
diff --git a/packages/seacas/applications/nem_slice/elb.h b/packages/seacas/applications/nem_slice/elb.h
@@ -14,7 +14,7 @@
 #include <string>
 #include <vector>
 
-#define ELB_VERSION "5.01"
+#define ELB_VERSION "5.02"
 #define UTIL_NAME   "nem_slice"
 #define ELB_FALSE   0
 #define ELB_TRUE    1

diff --git a/packages/seacas/applications/nem_slice/elb_loadbal.C b/packages/seacas/applications/nem_slice/elb_loadbal.C
@@ -1553,14 +1553,7 @@ namespace {
 
           size_t nhold = graph->sur_elem[side_nodes[0]].size();
           assert(nhold == 1 || nhold == 2);
-          if (nhold == 1) {
-            // Only a single element connected to this node -- at boundary of 1D domain
-            if (!categorized[ecnt]) {
-              lb->bor_elems[proce].push_back(ecnt);
-              categorized[ecnt] = 1;
-            }
-          }
-          else {
+          if (nhold == 2) {
             // 2 elements connected to this node -- `ecnt` and the other one...
             for (size_t ncnt = 0; ncnt < nhold; ncnt++) {
               size_t elem = graph->sur_elem[side_nodes[0]][ncnt];
@@ -1569,10 +1562,7 @@ namespace {
               }
               int proc2 = lb->vertex2proc[elem];
               if (proce == proc2) {
-                if (!categorized[ecnt]) {
-                  lb->int_elems[proce].push_back(ecnt);
-                  categorized[ecnt] = 1;
-                }
+                continue;
               }
               else {
                 // Processors of the two elements are different, so we are
@@ -1589,6 +1579,10 @@ namespace {
             }
           }
         }
+        if (!categorized[ecnt]) {
+          lb->int_elems[proce].push_back(ecnt);
+          categorized[ecnt] = 1;
+        }
       }
     }
     else {