Fixes for deb build and CI #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure .deb has a properly formatted version - Set version for everything in cmake to 6.0.0 (not intended to change, just a placeholder) - Add GitHub URL to package metadata - Fix architecture variable - Fix warning with old tags command
mgaliar
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Package version issue
I discovered this while attempting to install a bennu .deb file. It failed with a invalid version error.
CMake requires semantic versioning, e.g. MAJOR.MINOR.REVISION. Python setuptools also requires this. Debian archives are less restrictive, but require the release version start with an integer. This means the git commit short sha can't be used as a version, at least not directly. The workaround for this is to prepend a made-up version, I've used
6.0.0, which is two versions ahead of4.0.0(the last version of SCEPTRE before we ditched versioning). So, you'll get a version like6.0.0.f7055755, wheref7055755is the short sha sum of the latest commit in HEAD.Versions are defined in:
sceptre-bennu/CMakeLists.txtsceptre-bennu/cmake/CpackConfig.cmake(this gets it's version fromsceptre-bennu/CMakeLists.txt)sceptre-bennu/src/pybennu/setup.pysceptre-bennu/src/pybennu/MakefileVersions affect: