Add support for samba setup using ceph smb manager module

[anoopcs9]

• Enable and create samba shares with ceph smb mgr module.
• Explicit creation of samba users via users.setup is skipped(achieved through smb mgr module).
• Client access directed at node running smb service.

Finally, we have a new backend - cephfs.mgr.vfs 😀 .

[anoopcs9]

EXTRA_VARS="backend=cephfs.mgr.vfs test_sanity_only=1" make test

Above command successfully completed.

[phlogistonjohn]

Changes to add smb mgr module support look correct to me. I have some questions around how to possibly use the module more efficiently but I'd be fine with merging this as it is too.

[spuiuk]

ACK

[anoopcs9]

I've added the do-not-merge label to include the suggestions from @phlogistonjohn and @xhernandez in the current PR itself. I'll update shortly.

[anoopcs9]

Error ENOTSUP: Warning: due to ceph-mgr restart, some PG states may not be up to date\nModule 'smb' is not enabled/loaded (required by command 'smb apply'): use ceph mgr module enable smb to enable it

@phlogistonjohn
I happen to see this error on CI cluster(not locally for me) while trying to create smb cluster immediately after smb mgr module is enabled. May be we wait for mgr to be running after ceph mgr module enable smb?

[phlogistonjohn]

I happen to see this error on CI cluster(not locally for me) while trying to create smb cluster immediately after smb mgr module is enabled. May be we wait for mgr to be running after ceph mgr module enable smb?

Yes, try waiting or waiting longer. Enabling the module triggers a mgr restart and it's not the fastest.

[phlogistonjohn]

updated code lgtm (modulo the restart issue you are seeing)

[anoopcs9]

updated code lgtm (modulo the restart issue you are seeing)

Added a task to wait for mgr restart to complete and tests successfully passed 😊 .

[phlogistonjohn]

looks ok to me.

[anoopcs9]

updated code lgtm (modulo the restart issue you are seeing)

Added a task to wait for mgr restart to complete and tests successfully passed 😊 .

I spoke too soon. Full test suite run has some smbtorture failures.

[anoopcs9]

updated code lgtm (modulo the restart issue you are seeing)

Added a task to wait for mgr restart to complete and tests successfully passed 😊 .

I spoke too soon. Full test suite run has some smbtorture failures.

I think its good to start with the CI runs and eventually debug and provide fixes. Removing the do-not-merge label.