Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure unwrap client uses client config if available #96

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

lkubb
Copy link
Member

@lkubb lkubb commented Nov 7, 2024

What does this PR do?

Ensures the unwrap client uses client config if available. Also cleans up unnecessary Pylint pragmas in a second commit.

What issues does this PR fix or reference?

Fixes: #95

Previous Behavior

When unwrapping authentication credentials without having a preexisting cached configuration, the unwrap requests would not respect the vault:client configuration.

New Behavior

Works as expected.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 89.02439% with 18 lines in your changes missing coverage. Please review.

Project coverage is 90.78%. Comparing base (a3fd387) to head (585bc52).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
tests/unit/utils/vault/test_factory.py 80.88% 8 Missing and 5 partials ⚠️
tests/unit/utils/vault/conftest.py 81.48% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
- Coverage   90.83%   90.78%   -0.06%     
==========================================
  Files          77       77              
  Lines       13098    13147      +49     
  Branches     1215     1219       +4     
==========================================
+ Hits        11898    11935      +37     
- Misses        945      953       +8     
- Partials      255      259       +4     
Flag Coverage Δ
Linux 90.70% <89.02%> (-0.06%) ⬇️
macOS 66.40% <89.02%> (+0.03%) ⬆️
project 80.32% <100.00%> (+0.04%) ⬆️
py310 90.73% <89.02%> (-0.06%) ⬇️
py39 85.60% <89.02%> (-0.06%) ⬇️
salt_3006_9 85.68% <89.02%> (-0.04%) ⬇️
salt_3007_1 90.69% <89.02%> (-0.05%) ⬇️
tests 96.04% <88.88%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkubb lkubb merged commit 0e4d84e into salt-extensions:main Nov 7, 2024
22 checks passed
@lkubb lkubb deleted the fix/unwrap-client-config branch November 7, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Client configuration is sometimes not respected when unwrapping credentials
1 participant