Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with master cluster mode #100

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

lkubb
Copy link
Member

@lkubb lkubb commented Nov 10, 2024

What does this PR do?

Fix compatibility with master cluster mode

What issues does this PR fix or reference?

Fixes: #99

Previous Behavior

Crash because the pki_dir does not contain the minion's key, it's in cluster_pki_dir.

New Behavior

Works.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 90.52632% with 9 lines in your changes missing coverage. Please review.

Project coverage is 90.83%. Comparing base (0e4d84e) to head (9a44551).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...s/integration/runners/test_vault_master_cluster.py 87.30% 8 Missing ⚠️
src/saltext/vault/runners/vault.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   90.78%   90.83%   +0.05%     
==========================================
  Files          77       79       +2     
  Lines       13147    13231      +84     
  Branches     1219     1224       +5     
==========================================
+ Hits        11935    12018      +83     
  Misses        953      953              
- Partials      259      260       +1     
Flag Coverage Δ
Linux 90.75% <90.52%> (+0.05%) ⬆️
macOS 66.40% <56.84%> (-0.01%) ⬇️
project 80.49% <85.71%> (+0.17%) ⬆️
py310 90.78% <90.52%> (+0.05%) ⬆️
py39 85.47% <61.05%> (-0.13%) ⬇️
salt_3006_9 85.54% <61.05%> (-0.15%) ⬇️
salt_3007_1 90.74% <90.52%> (+0.05%) ⬆️
tests 95.99% <90.90%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkubb lkubb force-pushed the fix/master-cluster-pki-dir branch 7 times, most recently from e3a99d0 to e2de561 Compare November 10, 2024 20:19
@lkubb lkubb marked this pull request as ready for review November 10, 2024 21:29
@lkubb lkubb merged commit e757fb5 into salt-extensions:main Nov 10, 2024
22 checks passed
@lkubb lkubb deleted the fix/master-cluster-pki-dir branch November 10, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Compatible with 3007.1 and Master Cluster?
1 participant