-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support storing file on s3 #24
base: master
Are you sure you want to change the base?
Conversation
you only need to change the driver config on filesystem.php file from s3 to local or local to s3 to make it work
@tantam Can you please resolve the conflicts ? I will merge it. |
Looking forward for this change |
I just resolved on behavior of my code and tested it. |
@pratiksahu Can you please merge and tag it? |
@tantam I tried to pull your branch. but I get the following error when I try to upload a file: The error is from SahusoftCom\EloquentImageMutator\Dist\ImageService: |
@ido567 That function should exist by default in Laravel, you can check that function here: https://laravel.com/docs/5.4/filesystem#storing-files Can you tell me what is Default Filesystem Disk in your filesystems.php file, your laravel version ? |
@tantam My .env configurations are:
But I think I found the problem, this function was added in 5.3, but the package supports Laravel 5.1 and above (I use it with version 5.1). |
Yes, you are right. Can you able to update your laravel version ? I will change the code to fix that version, but can not do it now |
@tantam I can't.. upgrading from 5.1 to 5.4 is too complicated and it's gonna break some other packages. |
@TamTam any update on this? or have you shelved it? |
I have changed the code a little bit, so now when you change driver in filesystems.php file from local to s3, it is still working.
So now you can use local or s3 to store files.
Can you check them and accept my PR. If you don't understand anything, please let me know.
Thanks in advance.