Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support storing file on s3 #24

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

tantam
Copy link

@tantam tantam commented Mar 17, 2017

I have changed the code a little bit, so now when you change driver in filesystems.php file from local to s3, it is still working.
So now you can use local or s3 to store files.

Can you check them and accept my PR. If you don't understand anything, please let me know.

Thanks in advance.

you only need to change the driver config on filesystem.php file from s3 to local or local to s3 to make it work
@pratiksahu
Copy link
Member

@tantam Can you please resolve the conflicts ? I will merge it.

@ido567
Copy link

ido567 commented Jun 12, 2017

Looking forward for this change
@tantam can you please help with the conflict?

@tantam
Copy link
Author

tantam commented Jun 13, 2017

I just resolved on behavior of my code and tested it.
Everything for me is ok. Let me know if there is any issue, I will fix it

@ido567
Copy link

ido567 commented Jun 13, 2017

@pratiksahu Can you please merge and tag it?

@ido567
Copy link

ido567 commented Jun 13, 2017

@tantam I tried to pull your branch. but I get the following error when I try to upload a file:
image

The error is from SahusoftCom\EloquentImageMutator\Dist\ImageService:
image

@tantam
Copy link
Author

tantam commented Jun 14, 2017

@ido567 That function should exist by default in Laravel, you can check that function here: https://laravel.com/docs/5.4/filesystem#storing-files

Can you tell me what is Default Filesystem Disk in your filesystems.php file, your laravel version ?

@ido567
Copy link

ido567 commented Jun 14, 2017

@tantam My .env configurations are:

FILESYSTEM_DRIVER=s3
FILESYSTEM_CLOUD=s3

But I think I found the problem, this function was added in 5.3, but the package supports Laravel 5.1 and above (I use it with version 5.1).

@tantam
Copy link
Author

tantam commented Jun 14, 2017

Yes, you are right.

Can you able to update your laravel version ? I will change the code to fix that version, but can not do it now

@ido567
Copy link

ido567 commented Jun 14, 2017

@tantam I can't.. upgrading from 5.1 to 5.4 is too complicated and it's gonna break some other packages.
When do you think you will be able to fix this issue?

@samcambridge
Copy link

@TamTam any update on this? or have you shelved it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants