Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pass headers for GET and DELETE requests #149

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Feb 22, 2024

What it solves

We are using fetchData for POST, PUT and GET requests and have some logic in there to only set headers if there is a body. With the new endpoints added in #148 GET and DELETE requests now also contain headers so this doesn't work anymore.

How it is solved

I've also written more unit tests to cover these cases.

Copy link

github-actions bot commented Feb 22, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan usame-algan merged commit a723748 into main Feb 22, 2024
4 checks passed
@usame-algan usame-algan deleted the fix-headers branch February 22, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants