fix: Pass headers for GET and DELETE requests #149
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
We are using
fetchData
for POST, PUT and GET requests and have some logic in there to only set headers if there is a body. With the new endpoints added in #148 GET and DELETE requests now also contain headers so this doesn't work anymore.How it is solved
getData
fetchData
done in feat: register, change and verify email addresses #148headers
todeleteData
I've also written more unit tests to cover these cases.