-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mock postgres database v1 in more tests [SW-403] #2064
Conversation
I think the error there is related to a non-graceful app shutdown during the test execution, so maybe the database connections are not properly closed in your local setup. You can check the error in the CI there is
If the dependency graph is modified on purpose (and the auth-related modules are needed at startup), then you need to include placeholders for |
I believe that’s a different issue. This PR addresses a problem with the unit tests, whereas the issue you’re seeing in the PR is related to the e2e tests. You need to run unit tests and monitor your database connections as well to face the issue this PR fixes. |
The issue in the other branch is related to the unit tests, not e2e, as you can see in the screenshot. But I'm fine with the changes in the PR 👍 Thanks for looking into this @PooyaRaki ! |
Initially, it was also the e2e tests that were affected. Please take a look: |
Summary
Added PostgresDatabaseModule mock to additional unit tests to enhance test coverage and reliability.
When registering Notification V2, we encountered a "too many connections" error. To address this, we need to mock Database V1 and V2 in all tests. This PR adds the missing mocks.
Changes
How to test/reproduce