184994821 reformat scholarships page #21
Conversation
Gekerd patch 1
Scholarships link on home page
Add rspec scholarship
.DS_Store
Outdated
There was a problem hiding this comment.
This file should not be added to the commit. You should add it to the .gitignore.
app/views/.DS_Store
Outdated
There was a problem hiding this comment.
This file should not be added to the commit. You should add it to the .gitignore.
app/.DS_Store
Outdated
There was a problem hiding this comment.
This file should not be added to the commit. You should add it to the .gitignore.
spec/models/scholarship_spec.rb
Outdated
There was a problem hiding this comment.
Why are these tests commented out? Please either add a comment explaining this and maybe even a TODO to give guidelines for what future developers can do to fix them or just remove the tests altogether.
There was a problem hiding this comment.
Do I have to close this PR and re-open a new one after I fixed the issues?
|
@simonjov Hey Simon, I just added the DS_Stores to .gitignore, and removed the outdated test |
.gitignore
Outdated
| @@ -40,3 +40,8 @@ | |||
|
|
|||
| # Ignore application configuration | |||
| /config/application.yml | |||
|
|
|||
| # Ignore all the DS_Stores | |||
| /.DS_Store | |||
There was a problem hiding this comment.
You can do simply .DS_Store without including a / or any directories.
You will likely want to remove all the existing ones. find . -name .DS_Store -delete should do it
Replaced original styling with simplistic Bootstrap to keep style consistent with rest of app