refactor: clean up updateValueAndCaretPosition
#813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, this method was earlier used when the value is changing from props, but that logic is changed now. |
s-yadav
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
updateValueAndCaretPositionis used only oncesetCaretPositionandcaretPoswere always set to something staticsetCaretPosition: truecaretPosnot passed, henceundefinedThis PR removes these 2 params; and removes unnecessary checks
Note: not sure if these params were used for different purposes in the past, or if they are planned to used differently in the future, but they are not used as of right now, so I'm removing them.