Fix exposing fields for SyncDelegates #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, exposing fields expects the method to provide a full path to the fields, instead of a field relative to the parent object. For example, before this change the paths needed to be: `RimWorld.SocialCardUtility+<>c__DisplayClass42_1/roleChangeRitual`, `RimWorld.SocialCardUtility+<>c__DisplayClass42_1/ritualTarget`, `RimWorld.SocialCardUtility+<>c__DisplayClass42_1/CS$<>8__locals1/pawn` After this change, the paths now need to be: `roleChangeRitual`, `ritualTarget`, `CS$<>8__locals1/pawn`
SokyranTheDragon
added
fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, exposing fields expects the method to provide a full path to the fields, instead of a field relative to the parent object.
For example, before this change the paths needed to be:
RimWorld.SocialCardUtility+<>c__DisplayClass42_1/roleChangeRitual,RimWorld.SocialCardUtility+<>c__DisplayClass42_1/ritualTarget,RimWorld.SocialCardUtility+<>c__DisplayClass42_1/CS$<>8__locals1/pawnAfter this change, the paths now need to be:
roleChangeRitual,ritualTarget,CS$<>8__locals1/pawnOn top of that, exposing the fields had no effect on reading them, which caused reading to fail due to the types not having sync workers. This will fix it by actually exposing the fields while reading.