Skip to content

Commit

Permalink
PRS and ERS don't promote replicas taking backups (vitessio#16997)
Browse files Browse the repository at this point in the history
Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
  • Loading branch information
ejortegau authored and rvrangel committed Nov 21, 2024
1 parent fc4d396 commit 55d83d5
Show file tree
Hide file tree
Showing 22 changed files with 1,558 additions and 970 deletions.
5 changes: 5 additions & 0 deletions changelog/22.0/22.0.0/changelog.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Changelog of Vitess v22.0.0

### Enhancement
#### Cluster management
* Prefer not promoting replicas that are taking backups [#16997](https://github.com/vitessio/vitess/pull/16997)
13 changes: 13 additions & 0 deletions changelog/22.0/22.0.0/summary.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- **[Major Changes](#major-changes)**
- **[RPC Changes](#rpc-changes)**
- **[Prefer not promoting a replica that is currently taking a backup](#reparents-prefer-not-backing-up)**


## <a id="major-changes"/>Major Changes</a>
Expand All @@ -13,3 +14,15 @@
These are the RPC changes made in this release -

1. `GetTransactionInfo` RPC has been added to both `VtctldServer`, and `TabletManagerClient` interface. These RPCs are used to fecilitate the users in reading the state of an unresolved distributed transaction. This can be useful in debugging what went wrong and how to fix the problem.

### <a id="reparents-prefer-not-backing-up"/>Prefer not promoting a replica that is currently taking a backup

Emergency reparents now prefer not promoting replicas that are currently taking backups with a backup engine other than
`builtin`. Note that if there's only one suitable replica to promote, and it is taking a backup, it will still be
promoted.

For planned reparents, hosts taking backups with a backup engine other than `builtin` are filtered out of the list of
valid candidates. This means they will never get promoted - not even if there's no other candidates.

Note that behavior for `builtin` backups remains unchanged: a replica that is currently taking a `builtin` backup will
never be promoted, neither by planned nor by emergency reparents.
1 change: 1 addition & 0 deletions changelog/22.0/README.md
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
## v22.0
* **[22.0.0](22.0.0)**
* [Changelog](22.0.0/changelog.md)
225 changes: 123 additions & 102 deletions go/vt/proto/replicationdata/replicationdata.pb.go

Large diffs are not rendered by default.

70 changes: 70 additions & 0 deletions go/vt/proto/replicationdata/replicationdata_vtproto.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 55d83d5

Please sign in to comment.