Skip to content

Commit

Permalink
Allow empty commit message
Browse files Browse the repository at this point in the history
Although this is unlikely (or impossible?) to ever happen in practice,
I don't feel comfortable with crashing triagebot if it ever happens.
  • Loading branch information
ehuss committed Nov 29, 2024
1 parent 7cf03cd commit 6015826
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions src/handlers/milestone_prs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -158,12 +158,7 @@ async fn milestone_cargo(
// * Cargo's PR never got merged as fast-forward / rebase / squash merge.
commit.parents.len() == 2)
.filter_map(|commit| {
let first = commit
.commit
.message
.lines()
.next()
.expect("commit message");
let first = commit.commit.message.lines().next().unwrap_or_default();
merge_re.captures(first).map(|cap| {
cap.get(1)
.or_else(|| cap.get(2))
Expand Down

0 comments on commit 6015826

Please sign in to comment.