Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to include debug symbols #123

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

Bobo1239
Copy link
Contributor

@Bobo1239 Bobo1239 commented Aug 4, 2024

(Basically the same as #72.)

Motivation for this is that compiling ripgrep fails with linker errors without that flag:
cargo xwin build --target x86_64-pc-windows-msvc

error: linking with `lld-link` failed: exit status: 1
[...]
  = note: lld-link: error: Cannot use debug info for 'libcmt.lib(std_type_info_static.obj)' [LNK4099]
          >>> failed to load reference 'd:\a01\_work\5\s\binaries\amd64ret\lib\amd64\libcmt.amd64.pdb': No such file or directory
[...]

In contrast (with this PR):
rm -r ~/.cache/cargo-xwin/
cargo xwin build --target x86_64-pc-windows-msvc --xwin-include-debug-symbols
build succeeds

Admittedly I have no idea what exactly causes debug symbols to become necessary for compilation here. Some other projects I've tested compile successfully without debug symbols.

@messense messense merged commit 13af951 into rust-cross:main Aug 5, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants