fix: differentiate max witness script size upon context #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In 5a3989c: Can you instead add two named fields to the error variant, |
ChrisCho-H
force-pushed
the
fix/max-witness-script
branch
from
5a3989c
to
13a1318
Compare
|
Good idea! I've changed the err message including |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MaxWitnessScriptSizeExceededis used in the context ofSegwitV0andTap, where each of max witness script size differs. Moreover, even in the same context ofSegwitV0, max witness script size differ whether it's standard or consensus rule. I just letMaxWitnessScriptSizeExceededreceive paramusizeto differentiate max witness script size upon context, which can fix the wrong err message of"The Miniscript corresponding Script would be larger than MAX_STANDARD_P2WSH_SCRIPT_SIZE bytes."whenSegwitV0consensus andTapcontext