Do some checksum module improvements
#609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test vectors from BIP-380 that cover the checksum and character set, both valid and invalid.
|
Looks like network errors in CI, will kick it later. |
apoelstra
approved these changes
Oct 6, 2023
apoelstra
approved these changes
Oct 9, 2023
apoelstra
added a commit
that referenced
this pull request
Oct 12, 2023
fe1a6be Implement write_descriptor macro (Tobin C. Harding) e9eb9b1 Use bech32 instead of custom poly_mod function (Tobin C. Harding) Pull request description: This is just the last patch, the rest are in #609 now. The `checksum::poly_mod` function implements BCH codes to calculate a checksum (appended to descriptors). We recently released a version of BCH codes in `bech32`. We can implement the `bech32::Checksum` trait for BIP-380 and use the `primitives::checksum` module, removing the custom `poly_mod` function. ACKs for top commit: apoelstra: ACK fe1a6be Tree-SHA512: 7be33951669982ce7b7d2e32197e5eb9c40323d31785a6ed0e4d47c6200c7cb0d4aadbce54cf112511dd680cc09a33f0e580aa193e71164ceaeacfecd98a1b19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first 4 patches from #608, no changes.
Clean up and add some test vector unit tests.