Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Pin syn to 2.0.32 #598

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

danielabrozzoni
Copy link
Contributor

No description provided.

Recently syn 2.0.33 broke our MSRV by depending on proc-macro2 1.0.67
@danielabrozzoni danielabrozzoni changed the title CI: Pin regex CI: Pin syn to 2.0.32 Sep 15, 2023
@danielabrozzoni danielabrozzoni marked this pull request as ready for review September 15, 2023 14:58
@apoelstra
Copy link
Member

I'm a little surprised that any syn 2.0.x works with 1.48.

The point of the existing serde pins is to keep syn at 1.x. I wonder if it would be possible to remove or relax those now?

@apoelstra
Copy link
Member

My approach to this CI failure would be to look at whatever's depending on syn 2.x and downgrade that.

@apoelstra
Copy link
Member

On second thought, I don't care enough about the detailed reasons for serde deps to be breaking our shit. We should drop serde_derive which should eliminate all the proc-macro nastiness and move on. Which is a bigger project and independent of this PR.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3d5cf3b

@apoelstra apoelstra merged commit ff99a1f into rust-bitcoin:master Sep 15, 2023
16 checks passed
@yancyribbens
Copy link
Contributor

@danielabrozzoni thanks for fixing this! I looked into fixing this but I didn't think to try syn 2.0.x. How did you decide which version of syn to use?

@danielabrozzoni
Copy link
Contributor Author

@yancyribbens in this case I think I just looked at the compiler error and downgrade the syn dependency until it compiled. Generally, I think using cargo tree with the latest toolchain and using the output to figure out which of our dependencies is importing the broken dependency and pinning that is a better approach, as Andrew suggested above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants