-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Pin syn to 2.0.32 #598
Conversation
67f34fd
to
33c648b
Compare
Recently syn 2.0.33 broke our MSRV by depending on proc-macro2 1.0.67
33c648b
to
3d5cf3b
Compare
I'm a little surprised that any The point of the existing serde pins is to keep |
My approach to this CI failure would be to look at whatever's depending on syn 2.x and downgrade that. |
On second thought, I don't care enough about the detailed reasons for serde deps to be breaking our shit. We should drop serde_derive which should eliminate all the proc-macro nastiness and move on. Which is a bigger project and independent of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 3d5cf3b
@danielabrozzoni thanks for fixing this! I looked into fixing this but I didn't think to try syn 2.0.x. How did you decide which version of syn to use? |
@yancyribbens in this case I think I just looked at the compiler error and downgrade the syn dependency until it compiled. Generally, I think using |
No description provided.