Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline descriptor inner types #587

Closed
wants to merge 2 commits into from
Closed

Inline descriptor inner types #587

wants to merge 2 commits into from

Commits on Sep 25, 2023

  1. Add missing line of whitespace

    @tcharding
    tcharding committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    09d3aa5 View commit details
    Browse the repository at this point in the history

  2. Inline descriptor inner types 

    The `ShInner` and `WshInner` enum's provide no benefit that I can
discern. Both include only tuple variants with private tuple fields. We
can therefore inline the enums into `Sh` and `Wsh` respectively with no
loss of type safety. Doing so marginally simplifies the code, the
biggest benefit is it stops devs wondering why there is an inner type.
    @tcharding
    tcharding committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    5018656 View commit details
    Browse the repository at this point in the history