-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce line count #572
Reduce line count #572
Conversation
I think increasing |
But 0c7a972 looks good otherwise. |
0c7a972
to
93e7c3a
Compare
I split each config option change into a separate patch so they can be viewed easily. I actually think the only massive win is |
FTR docs say the values are a percentage of
|
93e7c3a
to
75d3fa8
Compare
Not really a fan of the Otherwise 75d3fa8 looks good. |
No worries, I'll drop that commit - that is exactly why I kept them all separate :) |
75d3fa8
to
1cab0b8
Compare
Force push removes the |
Just in case you go looking for it, this is the commit hash of the removed patch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 1cab0b8
1cab0b8
to
f41a70d
Compare
Rebased, no other changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK f41a70d
Set `rustfmt` config option `fn_single_line` to true and run the formatter.
Set `rustfmt` config option `fn_call_width` to 80 and run the formatter.
Set `rustfmt` config option `struct_lit_width` to true and run the formatter.
f41a70d
to
26bb52e
Compare
Re-done after |
@tcharding, what order do you prefer I merge the PRs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 26bb52e
This one first please, it will cause loads of conflicts but that is always going to be the case whenever it merges. I meant "first" as in out of my PRs, do other peoples before mine please, I'm happy to rebase. |
This PR is formatting changes only, totally non-urgent.
Reduce line count by setting a couple of rustfmt config options to be the same as they are in
rust-bitcoin
. Final patch removes whitespace in trait impl blocks, and was the impetus for this PR.