Fix struct unpacking in libraries #892
Merged
+36
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solidity unpacks struct elements in function signatures only as long as the function is not defined as part of the library, otherwise the struct is referenced by
libName.structName
. This PR adds an additional check on whether the contract is a library when generating a method signature to look up its selector inmethodIdentifiers
.E.g., Solidity generates
and not
as we expected.
This PR also adds a
struct
and a function taking it as a parameter to an existinglibrary
in a test suite.Note:
storage
is being added to the struct name if the location of the input parameter isstorage
; that is not implemented in this PR, I'll open a separate issue.