Refactor rule parsing #4699
Merged
Refactor rule parsing #4699
+160
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Such rules only seem to be generated when KORE anti-left is enabled.
tothtamas28
force-pushed
the
refactor-rule-parsing
branch
from
1d6f27c
to
d71f6f6
Compare
jberthold
approved these changes
Dec 3, 2024
Comment on lines
-205
to
+206
| case And(ops=(In(right=x), y)): | ||
| return (x,) + FunctionRule._get_patterns(y) | ||
| case And(ops=(In(left=EVar(), right=arg), rest)): | ||
| return (arg,) + FunctionRule._extract_args(rest) |
There was a problem hiding this comment.
Of course this relies on the order of arguments being consistent with the order of \in clauses... (before and after your change), but that's probably OK...
There was a problem hiding this comment.
Good catch. But since everything else also relies on a particular structure of terms, I'll just keep it this way until it causes issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppRule,CeilRule,EqualsRule