Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add kusto scalar functions: now(), toupper(), tolower() #43

Merged
merged 4 commits into from
Mar 5, 2024

Conversation

shellcromancer
Copy link
Contributor

Adds a few simple Kusto functions backed by ANSI SQL standard functions. Tested compatibility with ClickHouse, SQLite, Snowflake and Postgres engines.

@@ -711,14 +711,17 @@ var knownFunctions struct {
func initKnownFunctions() map[string]*functionRewrite {
knownFunctions.init.Do(func() {
knownFunctions.m = map[string]*functionRewrite{
"not": {write: writeNotFunction},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review note: sorted this list for personal pleasure. Let me know if y'all would prefer to not do that and keep the previous disorganization.

@ejcx ejcx requested a review from abraithwaite March 5, 2024 18:05
Copy link
Contributor

@abraithwaite abraithwaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thank you!

You'll be first to receive a sticker when we make them :-)

@abraithwaite abraithwaite merged commit 2f99ca8 into runreveal:main Mar 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants