Fix out-of-bounds read in GenerateRandomChars (#151)

rumblefrog · May 10, 2023 · 648813b · 648813b
1 parent 735a2c6
commit 648813b
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/client/Source-Chat-Relay.sp b/client/Source-Chat-Relay.sp
@@ -778,7 +778,7 @@ void GenerateRandomChars(char[] buffer, int buffersize, int len)
 	char charset[] = "adefghijstuv6789!@#$%^klmwxyz01bc2345nopqr&+=";
 
 	for (int i = 0; i < len; i++)
-		Format(buffer, buffersize, "%s%c", buffer, charset[GetRandomInt(0, sizeof charset)]);
+		Format(buffer, buffersize, "%s%c", buffer, charset[GetRandomInt(0, sizeof charset - 1)]);
 }
 
 void StripCharsByBytes(char[] sBuffer, int iSize, int iMaxBytes = 3)