Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding uuid transformation for airship #3884

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

shrouti1507
Copy link
Contributor

@shrouti1507 shrouti1507 commented Nov 18, 2024

What are the changes introduced in this PR?

ref: https://docs.airship.com/api/ua/#operation-api-custom-events-post
Our present implementation did not ensure that the session ID was converted to UUID format. Hence we have introduced that fix.

What is the related Linear task?

Resolves INT-2910

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@koladilip
Copy link
Contributor

e2e tested?

@shrouti1507
Copy link
Contributor Author

e2e tested?

yes

@shrouti1507 shrouti1507 self-assigned this Nov 18, 2024
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.47%. Comparing base (e90d2ad) to head (d8f82a2).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3884      +/-   ##
===========================================
+ Coverage    89.05%   90.47%   +1.41%     
===========================================
  Files          618      613       -5     
  Lines        33071    32258     -813     
  Branches      7814     7670     -144     
===========================================
- Hits         29452    29186     -266     
+ Misses        3336     2817     -519     
+ Partials       283      255      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 18, 2024

@shrouti1507 shrouti1507 merged commit a80f874 into develop Nov 18, 2024
27 of 33 checks passed
@shrouti1507 shrouti1507 deleted the fix.airship-session-id branch November 18, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants