Remove strongly held target from kvo targets hash #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah very nice work, and appreciate the specs too! Thanks! And a heads up, please try to keep the whitespace diffs out for future PRs :) |
clayallsopp
added a commit
that referenced
this pull request
Jul 23, 2014
Remove strongly held target from kvo targets hash
|
re: whitespace diffs... but look at how many bytes he removed! :) I'm a big fan of auto whitespace truncation in your text editor, so my PRs might have things like this too without even realizing it. |
|
Yeah, sorry about the whitespace. I noticed it after I submitted the PR and didn't think it warranted canceling and then opening a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue seems to also be resolved in this PR(#361), but has not been merged in yet. This PR resolves only the issue I ran into. I think keeping a strong reference in @targets is okay, as long as it is removed when no longer needed. The way it currently is, the target object will only be released when the observing object is also released(releasing @targets)