Fix category view of profiles #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that was broken due to a huge amount of profiles that had to pass through the profile_card_details method. We don't need to do that here because we can pass pagy different kinds of collections. We only need the pagy_arrays for the search results. All other types of results can be passed as an ActiveRecordRelation. We also refactored the profile_card_details to be a Struct. This allows us to use the same partial to display the profile cards with the different kinds of collections. Co-authored-by: Andy <andreas.hellwig@bitbirds.berlin>
It was still broken with 10 profiles IIRC. I'd say the reason was acts-as-taggable and how we didn't (still don't) understand how to prevent n+1 queries when using it. |
|
I only looked at the code though. I didn't check it out and try it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that was broken due to a huge amount of profiles that had to pass through the profile_card_details method.
We don't need to do that here because we can pass pagy different kinds of collections. We only need the pagy_arrays for the search results. All other types of results can be passed as an ActiveRecordRelation.
We also refactored the profile_card_details to be a Struct. This allows us to use the same partial to display the profile cards with the different kinds of collections.