remove the main_or_tag method altogether and remove an addional query…

… for finding the profile in the profile partial,

that means it makes no sense to use a struct in the search because in order to fetch the image of the profile we always needed to fetch the profile anyway and when you already have it like in the other index pages you are always loading the profile twice

app/controllers/profiles_controller.rb

@@ -130,7 +130,7 @@ def profile_params
   end
 
   def search_with_search_params
-    @profiles = matching_profiles.map(&:profile_card_details)
+    @profiles = matching_profiles
     @pagy, @records = pagy_array(@profiles)
     # search results aggregated according to certain attributes to display as filters
     aggs = ProfileGrouper.new(params[:locale], @profiles.map { |profile| profile[:id] }).agg_hash

app/models/category.rb

@@ -10,7 +10,6 @@ class Category < ApplicationRecord
 
   def self.sorted_categories
     Category.all.includes(:translations).order(:position)
-
   end
 
   def short_name

app/models/profile.rb

@@ -108,30 +108,6 @@ def self.typeahead(term, region: nil)
     suggestions.map { |s| s.downcase }.uniq
   end
 
-  Struct.new(
-    'ProfileCardDetails',
-    :id,
-    :fullname,
-    :iso_languages,
-    :city,
-    :willing_to_travel,
-    :nonprofit,
-    :main_topic_or_first_topic,
-    keyword_init: true
-  )
-
-  def profile_card_details
-    Struct::ProfileCardDetails.new(
-      id: id,
-      fullname: fullname,
-      iso_languages: iso_languages,
-      city: city,
-      willing_to_travel: willing_to_travel,
-      nonprofit: nonprofit,
-      main_topic_or_first_topic: main_topic_or_first_topic,
-    )
-  end
-
   def fullname
     "#{firstname} #{lastname}".strip
   end
@@ -150,12 +126,6 @@ def name_or_email
     fullname.present? ? fullname : email
   end
 
-  def main_topic_or_first_topic
-    return nil unless main_topic
-
-    main_topic
-  end
-
   # Try building a slug based on the following fields in
   # increasing order of specificity.
   def slug_candidate

app/views/profiles/_profile.html.erb

@@ -9,7 +9,7 @@
       </div>
       <div class="profile-subtitle">
         <p>
-          <%= profile.main_topic_or_first_topic.truncate(60) if profile.main_topic_or_first_topic %>
+          <%= profile.main_topic.truncate(60) if profile.main_topic %>
         </p>
         <div
           class="profile-tooltip"

app/views/profiles/_show.html.erb

@@ -35,12 +35,12 @@
       </p>
     <% end %>
     <!-- main topic -->
-    <% if @profile.main_topic_or_first_topic %>
+    <% if @profile.main_topic %>
       <p class="">
         <span class="font-weight-bold">
           <%= t(:main_topic, scope: 'profiles.show') %>
         </span>
-        <%= @profile.main_topic_or_first_topic %>
+        <%= @profile.main_topic %>
       </p>
     <% end %>
       <!-- twitter -->