Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make changes to color palette for header and charts #51

Merged
merged 1 commit into from
Sep 16, 2019

Conversation

alicetragedy
Copy link
Collaborator

As suggested in the screen comps in #36, I’ve made some changes to the look of the landing page:

  • A new colour for the header (taken from the speakerinnen website);
  • New colours for the donut charts;
  • Colours for the links in the event title that fit the teal palette;
  • a percentage sign in the donut chart to make the meaning of the numbers more explicit (with help from @jancborchardt and his amazing internet-search skills 😁)

Screenshot 2019-09-04 at 16 58 36

@jancborchardt jancborchardt added the enhancement New feature or request label Sep 4, 2019
Copy link
Collaborator

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 👍

Copy link
Member

@tyranja tyranja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicccce!

@jancborchardt
Copy link
Collaborator

@tyranja so @alicetragedy and I were wondering how in general the merging process looks like, also now that we have permission to do it. Would you always be the person to merge, or do we have a 1 or 2 👍 review process and then whenever there’s these 1 or 2 approvals and the checks pass it gets merged? :)

@jancborchardt
Copy link
Collaborator

@tyranja tomorrow @alicetragedy and I will have another coworking session, would it be ok for us to merge this one, #50 and also #49 in so we can continue to work based on that? :)

@tyranja
Copy link
Member

tyranja commented Sep 16, 2019

@jancborchardt @alicetragedy SORRY, I had to talk to Anne, because she is still head of that project but wants to get out. I just wanted to make sure, she agrees to the changes. Gonna merge and deploy asap.

@tyranja tyranja merged commit 53793af into master Sep 16, 2019
@jancborchardt jancborchardt deleted the styling-changes branch September 16, 2019 19:23
@jancborchardt
Copy link
Collaborator

@tyranja no worries, we ended up skipping our session cause I was also busy with Nextcloud conference. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants