-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widen constraint for elm-solve-deps-wasm
#636
base: master
Are you sure you want to change the base?
Conversation
Otherwise, npm whines. I'm rather surprised this didn't complain before. To be clear: this kept the same versions locked, it just updated the metadata.
Is this to save space in node_modules/ for those who install both elm-review and elm-test? |
Yeah. If we allow both versions, then it'll install the latest. If you install |
Manually edited the `package-lock.json` to force `elm-solve-deps-wasm` v2. Then, regenerated the lockfile to give `elm-test` the old version. Workaround for rtfeldman/node-test-runner#636.
@lydell, ping :) |
I’ve been waiting for a release of elm-review with bumps :) |
I think we're currently targeting a major (dropping Node 10&12), so it'll probably be a while before we release, but this breaks our CI (we depend on 2.0.0's types internally). Alternatively, @jfmengels, would you be ok with backporting the |
@lishaduck I think we're still on course for v2 for |
There’s no rush with this, right? The new version does not bring any improvements to end users? |
|
Allow
elm-solve-deps-wasm
v2.CC: @lydell.