Skip to content

Commit

Permalink
Switch to dependabot for node_modules updates
Browse files Browse the repository at this point in the history
Pin our devDependencies, as they will now be updated via dependabot in a
more controlled fashion.
  • Loading branch information
jelly authored and martinpitt committed Oct 4, 2023
1 parent fd698c1 commit 05e6049
Show file tree
Hide file tree
Showing 6 changed files with 140 additions and 118 deletions.
26 changes: 26 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
version: 2
updates:
- package-ecosystem: "npm"
directory: "/"
schedule:
interval: "daily"
commit-message:
prefix: "[no-test]"
labels:
- "node_modules"
groups:
eslint:
patterns:
- "eslint*"
esbuild:
patterns:
- "esbuild*"
stylelint:
patterns:
- "stylelint*"
xterm:
patterns:
- "xterm*"
patternfly:
patterns:
- "@patternfly*"
82 changes: 82 additions & 0 deletions .github/workflows/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
name: update node_modules
on:
pull_request_target:
types: [opened, reopened, synchronize, labeled]

jobs:
dependabot:
environment: npm-update
permissions:
contents: read
pull-requests: write
timeout-minutes: 5
# 22.04's podman has issues with piping and causes tar errors
runs-on: ubuntu-20.04
if: ${{ contains(github.event.pull_request.labels.*.name, 'node_modules') }}

steps:
- name: Clone repository
uses: actions/checkout@v3
with:
ref: ${{ github.event.pull_request.head.ref }}
repository: ${{ github.event.pull_request.head.repo.full_name }}
fetch-depth: 0

- name: Clear node_modules label
uses: actions/github-script@v6
with:
script: |
try {
await github.rest.issues.removeLabel({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: context.issue.number,
name: 'node_modules'
});
} catch (e) {
if (e.name == 'HttpError' && e.status == 404) {
/* expected: 404 if label is unset */
} else {
throw e;
}
}
- name: Update node_modules for package.json changes
run: |
make tools/node-modules
git config --global user.name "GitHub Workflow"
git config --global user.email "cockpituous@cockpit-project.org"
eval $(ssh-agent)
ssh-add - <<< '${{ secrets.NODE_CACHE_DEPLOY_KEY }}'
./tools/node-modules install
./tools/node-modules push
git add node_modules
ssh-add -D
ssh-agent -k
- name: Clear [no-test] prefix from PR title
if: ${{ contains(github.event.pull_request.title, '[no-test]') }}
uses: actions/github-script@v6
env:
TITLE: '${{ github.event.pull_request.title }}'
with:
script: |
const title = process.env['TITLE'].replace(/\[no-test\]\W+ /, '')
await github.rest.pulls.update({
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: context.issue.number,
title,
});
- name: Force push node_modules update
run: |
# Dependabot prefixes the commit with [no-test] which we don't want to keep in the commit
title=$(git show --pretty="%s" -s | sed -E "s/\[no-test\]\W+ //")
body=$(git show -s --pretty="%b")
git commit --amend -m "${title}" -m "${body}" --no-edit node_modules
eval $(ssh-agent)
ssh-add - <<< '${{ secrets.SELF_DEPLOY_KEY }}'
git push --force 'git@github.com:${{ github.repository }}' '${{ github.head_ref }}'
ssh-add -D
ssh-agent -k
43 changes: 0 additions & 43 deletions .github/workflows/npm-update-pf.yml

This file was deleted.

43 changes: 0 additions & 43 deletions .github/workflows/npm-update.yml

This file was deleted.

2 changes: 1 addition & 1 deletion node_modules
Submodule node_modules updated 1407 files
62 changes: 31 additions & 31 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,37 +25,37 @@
"xterm-addon-canvas": "0.5.0"
},
"devDependencies": {
"argparse": "^2.0.1",
"axe-core": "^3.5.2",
"chrome-remote-interface": "^0.32.1",
"cssnano-preset-lite": "^2.0.1",
"esbuild": "^0.19.1",
"esbuild-plugin-copy": "^2.1.1",
"esbuild-plugin-replace": "^1.3.0",
"esbuild-sass-plugin": "^2.10.0",
"esbuild-wasm": "^0.19.1",
"eslint": "^8.29.0",
"eslint-config-standard": "^17.0.0",
"eslint-config-standard-jsx": "^11.0.0",
"eslint-config-standard-react": "^13.0.0",
"eslint-plugin-import": "^2.27.5",
"eslint-plugin-jsx-a11y": "^6.7.1",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-promise": "^6.1.1",
"eslint-plugin-react": "^7.32.2",
"eslint-plugin-react-hooks": "^4.6.0",
"gettext-parser": "^7.0.1",
"htmlparser": "^1.7.7",
"jed": "^1.1.1",
"qunit": "^2.19.0",
"qunit-tap": "^1.5.1",
"sass": "^1.59.3",
"sizzle": "^2.3.5",
"stylelint": "^14.16.1",
"stylelint-config-standard": "^25.0.0",
"stylelint-config-standard-scss": "^4.0.0",
"stylelint-formatter-pretty": "^3.1.1",
"stylelint-use-logical-spec": "^5.0.0"
"argparse": "2.0.1",
"axe-core": "3.5.2",
"chrome-remote-interface": "0.32.1",
"cssnano-preset-lite": "2.0.1",
"esbuild": "0.19.1",
"esbuild-plugin-copy": "2.1.1",
"esbuild-plugin-replace": "1.3.0",
"esbuild-sass-plugin": "2.15.0",
"esbuild-wasm": "0.19.1",
"eslint": "8.29.0",
"eslint-config-standard": "17.0.0",
"eslint-config-standard-jsx": "11.0.0",
"eslint-config-standard-react": "13.0.0",
"eslint-plugin-import": "2.27.5",
"eslint-plugin-jsx-a11y": "6.7.1",
"eslint-plugin-node": "11.1.0",
"eslint-plugin-promise": "6.1.1",
"eslint-plugin-react": "7.32.2",
"eslint-plugin-react-hooks": "4.6.0",
"gettext-parser": "7.0.1",
"htmlparser": "1.7.7",
"jed": "1.1.1",
"qunit": "2.19.0",
"qunit-tap": "1.5.1",
"sass": "1.59.3",
"sizzle": "2.3.5",
"stylelint": "14.16.1",
"stylelint-config-standard": "25.0.0",
"stylelint-config-standard-scss": "4.0.0",
"stylelint-formatter-pretty": "3.1.1",
"stylelint-use-logical-spec": "5.0.0"
},
"scripts": {
"eslint": "eslint --ext .js --ext .jsx pkg/ test/common/",
Expand Down

0 comments on commit 05e6049

Please sign in to comment.