Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix newspaper header issues #169

Merged
merged 1 commit into from
Jun 16, 2024
Merged

Fix newspaper header issues #169

merged 1 commit into from
Jun 16, 2024

Conversation

entorb
Copy link
Collaborator

@entorb entorb commented Jun 15, 2024

fixes #168

at @rrthomas : added slight adjustments to the LaTeX code to make .tex -> .html conversion more robust, please check (output should be uploaded here in approx 20 min)

@entorb
Copy link
Collaborator Author

entorb commented Jun 15, 2024

build of branch fails, I assume it is a bug in the pipeline. locally it works:

PDF:
image
HTML/epub:
image

@rrthomas
Copy link
Owner

build of branch fails, I assume it is a bug in the pipeline. locally it works:

I don't understand where the failure is! In the PR conversation it says "All checks have passed". On the checks page, the balance of red/green implies that 50% of the checks failed. But only one check is shown, and it passed. Further, in the global Actions page, the pipeline run for this PR is shown as green.

Anyway, thanks for fixing this, and the LaTeX changes look fine to me.

@rrthomas
Copy link
Owner

Ah, also the checks page reached directly from the global actions page shows green and is just one check. It's only the PR's checks page that shows red, and it doesn't show any failed check. Odd.

@entorb
Copy link
Collaborator Author

entorb commented Jun 16, 2024

I manually triggered the build action, that one failed. Will now merge and hope that on main branch it works as expected (and locally)

@entorb entorb merged commit dee9d3f into main Jun 16, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beginning of Chapter 86: Newspaper names are missing.
2 participants