Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#113 Remove temporary directory in the output of a git analysis #168

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ibe-314
Copy link
Collaborator

@ibe-314 ibe-314 commented Jul 13, 2024

When analyzing a remote git repository a temporary folder is created. The output contained the name of this temporary folder. This commit removes the temporary directory from the displayed output path. Therefore, a new dataclass called PathData is introduced to contain the source path and temporary directory information of a path.

Close #113

When analyzing a remote git repository a temporary folder is created. The output contained the name of this temporary folder. This commit removes the temporary directory from the displayed output path.
Therefore, a new dataclass called PathData is introduced to contain the source path and temporary directory information of a path.
@coveralls
Copy link

coveralls commented Jul 13, 2024

Coverage Status

coverage: 95.877% (+0.03%) from 95.848%
when pulling acbda7b on 113-clean-up-temp-folder-in-output-of-git-analysis
into 2cc2c62 on main.

…t-of-git-analysis

; Conflicts:
;	docs/changes.rst
@roskakori roskakori self-requested a review July 13, 2024 17:15
@roskakori
Copy link
Owner

@ibe-314 Looks good. I wait for #89 to be merged because after that this might need a couple of changes. But I can take care of that.

@e-io
Copy link
Collaborator

e-io commented Aug 19, 2024

@roskakori, I suggest merging this pull request now. I like how it's realized.

Regarding issue #89, I was re-writing it yesterday, I got stuck; and I realized it would be just as easy to re-write it after this pull request is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up temp folder in output of git analysis
4 participants