Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client:call generates TimeoutError exception when it is timed out. #1271

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from
Open

Client:call generates TimeoutError exception when it is timed out. #1271

wants to merge 2 commits into from

Conversation

fujitatomoya
Copy link
Collaborator

follow-up of #1188 (#1188 (comment))

@fujitatomoya fujitatomoya mentioned this pull request Apr 13, 2024
Merged
@fujitatomoya
Copy link
Collaborator Author

@sloretz @clalancette can you take a look at this?

@fujitatomoya fujitatomoya self-assigned this Apr 13, 2024
tonynajjar
tonynajjar approved these changes Apr 13, 2024
View reviewed changes
Copy link
Contributor

@tonynajjar tonynajjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fujitatomoya fujitatomoya force-pushed the fujitatomoya/client-call-timeout-exception branch from a13ba99 to e259bcf Compare June 25, 2024 19:55
@fujitatomoya
Copy link
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

@wjwwood requesting another review when you have time.

@fujitatomoya
Client:call generates TimeoutError exception when it is timed out.
7818334 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
call Thread.is_alive() to make sure the thread has started.
aeeef82 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya force-pushed the fujitatomoya/client-call-timeout-exception branch from 3d20396 to aeeef82 Compare August 21, 2024 18:35
@fujitatomoya
Copy link
Collaborator Author

fujitatomoya commented Aug 21, 2024 •
edited
Loading

Pulls: #1271
Gist: https://gist.githubusercontent.com/fujitatomoya/759f2057172ea84727982e4935290a86/raw/429214810f6a09aa7146f7ca06492faa60d1eb3a/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy --packages-above rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14432

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

@clalancette @sloretz can you review this?

@fujitatomoya
Copy link
Collaborator Author

Pulls: #1271
Gist: https://gist.githubusercontent.com/fujitatomoya/a040012520bd27673c877256eff6f36d/raw/429214810f6a09aa7146f7ca06492faa60d1eb3a/ros2.repos
BUILD args: --packages-up-to rclpy
TEST args: --packages-select rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14434

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonynajjar tonynajjar tonynajjar approved these changes

@sloretz sloretz Awaiting requested review from sloretz

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995

@wjwwood wjwwood Awaiting requested review from wjwwood

Assignees

@fujitatomoya fujitatomoya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fujitatomoya @wjwwood @tonynajjar