-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add external axes support #88
Add external axes support #88
Conversation
So I find this PR hard to review, as I cannot (readily) test it. Will the State Machine addin require any changes for this to work? What is the limit on the nr of tasks that could be added this way? |
I hope you believe me if I say I have tested it enough 😄
The Regardless,
If I remember correctly, then EGM can only handle 4 simultaneous channels. And I think the limit of RAPID tasks is 20 (with the |
Whether I believe you is irrelevant. The whole point of doing these reviews is to catch potential problems caused by using the code with setups you haven't/didn't consider(ed). |
Naturally. However, as far as I know, I am probably the only one with any deeper understanding of the implementation, so it is of course difficult for anyone else to make anything expect a cursory review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to at some (minimal) documentation on how to setup such a system (ie: with an external axis), but perhaps this should be done on the side of the add-in.
Thanks @jontje. |
Thanks for the review @gavanderhoorn, much appreciated!
Agreed, and I think it would make most sense to include it in the issue for sample codes, |
As per title.
This PR partially fixes issue #20.
Example:
It will now be possible to use
abb_libegm
to control a system that has one RAPID motion task for a robot, and one motion RAPID task for a track, by setting up an EGM communication channel for each of the them. And a system could look like this: