Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for new chromedriver location (extended) #39

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Fix for new chromedriver location (extended) #39

wants to merge 17 commits into from

Conversation

ashbythorpe
Copy link

Extends #35

@ashbythorpe
Copy link
Author

All checks pass! 🎉
Now I just need to make sure older versions of Chromedriver will continue to work, and then this can be merged.

@ashbythorpe
Copy link
Author

Finished! This PR fixes #34, allowing Chromedriver to be downloaded from the Chrome for Testing site, while still allowing old versions of the driver to be downloaded from the previous site.

@ashbythorpe ashbythorpe marked this pull request as ready for review October 25, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashbythorpe @dmurdoch @jonathanvoelkle