This repository has been archived by the owner on May 10, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Prototype of an aggs parser handle. #8
Open
statwonk
wants to merge
25
commits into
ropensci-archive:master
Choose a base branch
from
statwonk:aggs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it might be nice to shoot for a syntax like, The challenge comes in with nesting ... |
thanks! I'll have a look in the morning |
for my own reference: http://adv-r.had.co.nz/dsl.html |
Probably is good, But let me get the #6 sorted out first, then it'll be easier to play with this |
👍 One thing of mention re: last call, I think a |
put old piper in inst/ignore
works for some, but likely will need more work to work in all cases
yeah, see #12 |
…ests Add a few more tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more of a proposal than anything and I don't intend for a merge into
master
, at least not withstanding major polishing. Here's my little toy code for playing withaggs
parsers. It's not recursive, which would be nice to have. @sckott as you'll see there's a departure from your structure. I'm a bit of a newcomer to lazy evaluation, so I'm sure that I'm missing important features. Comments are appreciated!