Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Disable script concatenation by default #717

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

retlehs
Copy link
Member

@retlehs retlehs commented Apr 24, 2024

This PR sets CONCATENATE_SCRIPTS to false by default which prevents WordPress from concatenating scripts

Ref https://discourse.roots.io/t/upstream-timed-out-for-load-styles-php/26973

@retlehs retlehs self-assigned this Apr 24, 2024
@tangrufus
Copy link
Collaborator

tangrufus commented Apr 29, 2024

Should we take it one step further to disable COMPRESS_SCRIPTS, COMPRESS_CSS and ENFORCE_GZIP as well?

The CDN and web servers (e.g: nginx, apache, etc) should take care of those.

@slackday
Copy link
Contributor

slackday commented Oct 24, 2024

I started getting problems with this after updating nginx from 1.21.7 to 1.27.2. Not with timeout to load-styles.php like many people report but nginx would just return connection reset by peer.

Setting CONCATENATE_SCRIPTS to false solved the problem. Not sure why it happens but seems WordPress does something not compatible with latest nginx.

@robrecord
Copy link

robrecord commented Nov 27, 2024

Should we take it one step further to disable COMPRESS_SCRIPTS, COMPRESS_CSS and ENFORCE_GZIP as well?

Yes, I agree with @tangrufus - although those additions could become a separate issue/PR.

Is there anything else preventing this PR being merged as it currently stands? It would be a great feature to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants