Fix incorrect JSON response for 'blockchain.transaction.get' RPC

Daemon::get_transaction_hex should return a string, not a dictionary.
romanz · Aug 24, 2021 · ffab4f4 · ffab4f4
1 parent c7eb0ba
commit ffab4f4
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/daemon.rs b/src/daemon.rs
@@ -1,6 +1,8 @@
 use anyhow::{Context, Result};
 
-use bitcoin::{Amount, Block, BlockHash, Transaction, Txid};
+use bitcoin::{
+    consensus::serialize, hashes::hex::ToHex, Amount, Block, BlockHash, Transaction, Txid,
+};
 use bitcoincore_rpc::{self, json, RpcApi};
 use parking_lot::Mutex;
 use serde_json::{json, Value};
@@ -144,10 +146,9 @@ impl Daemon {
         &self,
         txid: &Txid,
         blockhash: Option<BlockHash>,
-    ) -> Result<json::GetRawTransactionResult> {
-        self.rpc
-            .get_raw_transaction_info(txid, blockhash.as_ref())
-            .context("failed to get transaction info")
+    ) -> Result<Value> {
+        let tx = self.get_transaction(txid, blockhash)?;
+        Ok(json!(serialize(&tx).to_hex()))
     }
 
     pub(crate) fn get_transaction(