[v6] Add react-bootstrap theme to replace bootstrap-4 (#3638) #3974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickgros
commented
Nov 25, 2023
| "@rjsf/chakra-ui": "^5.14.2", | ||
| "@rjsf/core": "^5.14.2", | ||
| "@rjsf/fluent-ui": "^5.14.2", | ||
| "@rjsf/fluentui-rc": "^5.14.2", | ||
| "@rjsf/material-ui": "^5.14.2", | ||
| "@rjsf/mui": "^5.14.2", | ||
| "@rjsf/react-bootstrap": "file:../react-bootstrap", |
There was a problem hiding this comment.
This lets me build the playground without releasing the theme to NPM. We can update this to the version number once we release a v6 beta.
|
Converting to draft until we get CI working for rjsf-v6 branch |
|
@nickgros I guess the first thing we need to do is create the long-lived branch |
Merged
- Add react-bootstrap package and use react-bootstrap v2, corresponding to Bootstrap 5 - CheckboxesWidget: Remove deprecated prop `custom` - IconButton: Remove deprecated `block` prop - RangeWidget: Use `FormRange` component - SelectWidget: Use new FormSelect component, remove `bsPrefix` prop to achieve correct styling
CHANGELOG.md
Outdated
| @@ -15,6 +15,21 @@ it according to semantic versioning. For example, if your PR adds a breaking cha | |||
| should change the heading of the (upcoming) version to include a major version bump. | |||
|
|
|||
| --> | |||
| # 6.0.0 | |||
There was a problem hiding this comment.
Suggested change
| # 6.0.0 | |
| # 6.0.0-beta.1 |
packages/react-bootstrap/README.md
Outdated
|
|
||
| ### Built With | ||
|
|
||
| - [react-jsonschema-form](https://github.com/mozilla-services/react-jsonschema-form/) | ||
| - [Bootstrap-4](https://getbootstrap.com/docs/4.0/) | ||
| - [Bootstrap-5](https://getbootstrap.com/docs/4.0/) |
| "version": "5.15.0", | ||
| "main": "dist/index.js", | ||
| "module": "lib/index.js", | ||
| "typings": "lib/index.d.ts", | ||
| "description": "Bootstrap 4 theme, fields and widgets for react-jsonschema-form", | ||
| "description": "Bootstrap 5 theme, fields and widgets for react-jsonschema-form, powered by react-bootstrap", |
There was a problem hiding this comment.
Consider calling this React Bootstrap theme
Comment on lines
85
to
86
| "bootstrap-5", | ||
| "rjsf-bootstrap-5" |
There was a problem hiding this comment.
add react-bootstrap, rjsf-react-bootstrap
|
|
||
| ## @rjsf/bootstrap-4 | ||
|
|
||
| - Package has been replaced with `@rjsf/react-bootstrap`. `react-boostrap` v1 / Bootstrap 4 are no longer supported in RJSF v6. |
There was a problem hiding this comment.
Also, add this to the migration guide with breaking changes?
heath-freenome
approved these changes
Jan 5, 2024
8 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3638
Add react-bootstrap package and use react-bootstrap v2, corresponding to Bootstrap 5
CheckboxesWidget: Remove deprecated prop
customIconButton: Remove deprecated
blockpropRangeWidget: Use
FormRangecomponentSelectWidget: Use new FormSelect component, remove
bsPrefixprop to achieve correct stylingI'm updating documentation
I'm adding or updating code
npm run test:updateto update snapshots, if needed.I'm adding a new feature