Make fields with const pre-fiiled and readonly
#3843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -177,6 +185,8 @@ export function computeDefaults<T = any, S extends StrictRJSFSchema = RJSFSchema | |||
| defaults = mergeObjects(defaults!, schema.default as GenericObjectType) as T; | |||
| } else if (DEFAULT_KEY in schema) { | |||
| defaults = schema.default as unknown as T; | |||
| } else if (CONST_KEY in schema) { | |||
| defaults = schema.const as unknown as T; | |||
There was a problem hiding this comment.
Const are different than defaults in that they should ALWAYS be set regardless of those values of the experimental_defaultFormStateBehavior.emptyObjectFields that restrict how defaults are set. I'm not entirely sure the best approach to updating maybeAddDefaultToObject() to understand the difference. I'm curious to see what you come up with. Maybe passing parentConsts along side of parentDefaults?
8 tasks
heath-freenome
added a commit
that referenced
this pull request
Oct 21, 2024
* Make fields with const pre-fiiled and readonl * fixed issue with default on root level. * fixed array const populate values * fixed array issue and written tests to cover the behavior * updated changeLog * fixed issue with core failing tests. * changed changeLog to rerun tests * improvement based on feedback * Update packages/utils/test/schema/getDefaultFormStateTest.ts Adding default that should not be used * Update packages/utils/test/schema/getDefaultFormStateTest.ts Fix linter --------- Co-authored-by: Abdallah Al-Soqatri <abdallah.al-soqatri@aspentech.com> Co-authored-by: Heath C <51679588+heath-freenome@users.noreply.github.com>
|
This issue has been automatically marked as possibly close because it has not had recent activity. It will be closed if no further activity occurs. Please leave a comment if this is still an issue for you. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
fixes #2600
If fields have
constdefinition, make the value as pre-filled default and also make the fields readonly. (current logic will just ignore theconstvalue and leave blank input for users.Checklist
npm run test:updateto update snapshots, if needed.