Merge pull request #190 from rhpvorderman/release_0.11.1

Release 0.11.1
rhpvorderman · Aug 12, 2024 · 124690c · 124690c
2 parents b4d0f6f + fe05cff
commit 124690c
Show file tree

Hide file tree

Showing 5 changed files with 250 additions and 254 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -7,6 +7,11 @@ Changelog
 .. This document is user facing. Please word the changes in such a way
 .. that users understand how the changes affect the new version.
 
+version 0.11.1
+------------------
++ Fix a memory leak that occurred in Python 3.12 due to a refcounting API
+  change.
+
 version 0.11.0
 ------------------
 + Make figure IDs reproducible across HTML reports.

diff --git a/docs/reports/21C125_R1.fastq.gz.html b/docs/reports/21C125_R1.fastq.gz.html
diff --git a/docs/reports/GM24385_1.fastq.gz.html b/docs/reports/GM24385_1.fastq.gz.html
diff --git a/docs/reports/GM24385_1_cut.fastq.gz.html b/docs/reports/GM24385_1_cut.fastq.gz.html
diff --git a/src/sequali/_qcmodule.c b/src/sequali/_qcmodule.c
@@ -32,12 +32,6 @@ along with Sequali.  If not, see <https://www.gnu.org/licenses/
 #include "emmintrin.h"
 #endif
 
-#if (PY_VERSION_HEX < 0x03090000)
-#define Py_SET_REFCNT(op, count) (Py_REFCNT(op) = count)
-#define Py_SET_SIZE(op, size) (Py_SIZE(op) = size)
-#define Py_SET_TYPE(op, type) (Py_TYPE(op) = type)
-#endif
-
 /* Pointers to types that will be imported in the module initialization section */
 
 static PyTypeObject *PythonArray;  // array.array
@@ -538,14 +532,11 @@ FastqRecordArrayView_FromPointerSizeAndObject(struct FastqMeta *records,
                                               PyObject *obj)
 {
     size_t size = number_of_records * sizeof(struct FastqMeta);
-    FastqRecordArrayView *self =
-        PyObject_Malloc(sizeof(FastqRecordArrayView) + size);
+    FastqRecordArrayView *self = PyObject_NewVar(
+        FastqRecordArrayView, &FastqRecordArrayView_Type, number_of_records);
     if (self == NULL) {
         return PyErr_NoMemory();
     }
-    Py_SET_REFCNT(self, 1);
-    Py_SET_TYPE(self, &FastqRecordArrayView_Type);
-    Py_SET_SIZE(self, number_of_records);
     if (records != NULL) {
         memcpy(self->records, records, size);
     }