Add new extractByIndex method #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add an `extractByIndex()` method to subset/extract content from a `MsBackend`. Using this method in contrast to `[` avoids errors with some parallel processing setups in which a `[` method for a backend might not be found (see rformassspectrometry/MsBackendMetaboLights#5).
|
Update: just added a backward compatibility that fails back to use |
philouail
reviewed
Sep 27, 2024
| Below we implement a possible `[` for our test backend class. We ignore the | ||
| parameters `j` from the definition of the `[` generic, since we treat our data | ||
| to be one-dimensional (with each spectrum being one element). | ||
| The `extractByIndex()` method is used by the data operation and analysis methods |
There was a problem hiding this comment.
just so I understand, from now on when we need to implement some code in Spectra we have to use extractByIndex() instead of [ ?
There was a problem hiding this comment.
we can use both - but it would be better to use extractByIndex.
philouail
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new generic and method
extractByIndex()to subset/extract data from aMsBackendgivenintegerindices. Properties:[method callsextractByIndex(), converting first parameterito aninteger.Spectrause nowextractByIndex()to subset the backend instead of[:combineSpectra()MsBackendMetaboLights#5Disadvantage:
MsBackendimplementation must implement this method now. So, I'll need to fix the other backend classes/packages accordingly.Open to discussion.