feat: add MsBackendMetaboLights import/export #20
Conversation
- Add save/read support for `MsBackendMetaboLights` objects.
|
Need to wait for the |
| dir.create(path = path, recursive = TRUE, showWarnings = FALSE) | ||
| saveObjectFile(path, "ms_backend_mz_r", | ||
| list(ms_backend_mz_r =list(version = "1.0"))) | ||
| l <- list(list(version = version)) |
There was a problem hiding this comment.
I am a bit confused about the list(list()). and then you name it 'ms_backend_mzr` into it next line ? why does it need to be a list of a list ?
There was a problem hiding this comment.
This is the particular format saveObjectFile want the input parameter, i.e. a list with all optional parameters (one of them being version and the name of that list should be the name/type of the object. It's confusing, I agree, but I don't know how to call it differently, given that we want to support setting the type with parameter object of the upstream function.
R/PlainTextParam.R
Outdated
| @@ -48,6 +51,11 @@ | |||
| #' `readMsObject()` functions for other classes (such as `Spectra`, | |||
| #' `MsExperiment` etc). | |||
| #' | |||
| #' @param offline For `readMsObject()` to load MS data as a | |||
| #' `MsBackendMetaboLights()`: `logical(1)` to evaluate the local file cache | |||
| #' and only load local files. Thus `offline = TRUE` does not need an active | |||
There was a problem hiding this comment.
I would avoid repetition maybe and instead maybe ..to evaluate **only** the local file cache ?
There was a problem hiding this comment.
Done with the latest commit.
|
Thanks for the review Phili! |
MsBackendMetaboLightsobjects.