Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always construct a new http docs field #62

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

Jeffail
Copy link
Collaborator

@Jeffail Jeffail commented Jul 22, 2024

Having a static http field can cause data races when instanciating multiple stream builders, as they mutate the default value of that field.

Ref: warpstreamlabs/bento#82

Copy link
Collaborator

@mihaitodor mihaitodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@Jeffail Jeffail merged commit e51c523 into main Jul 22, 2024
3 checks passed
@Jeffail Jeffail deleted the fix-http-field-race branch July 22, 2024 11:46
@nickzelei
Copy link

Thank you for the quick fix @Jeffail !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants